From: "Peter E. Berger" <pberger@xxxxxxxxxxx>
While working on a previous patchset for this driver [1] we were
hampered by the facts that download_fw() is very long and its return
paths are so complicated. Thus we were compelled to put the patched
request_firmware() call in edge_startup(), when it much more naturally
belongs to download_fw().
The primary purpose of this patchset is to move the bulk of the
download_fw() code into two helper functions, to cleanup the return
paths and to migrate the request_firmware() call into download_fw().
I welcome any comments or suggestions.
Thanks.
--Peter
Changes since v1 [2]
Addressing comments from Oliver, Sergei and Johan. Thanks to you all!
. Following discussion between Oliver and Johan, use serial->interface
for messages in download_fw().
. Fix wording in commit message for "Remove obsolete dev..." patch.
. Drop an unrelated whitespace change in the "Move request firmware..." patch.
. Move comment formatting fixups to a separate patch and cover the whole
source file (rather than just fixing up the patched sections).
. Squash indentation fixups into the "Move download..." patch.
. Move position of call to check_fw_sanity() in download_fw().
[1]: http://marc.info/?l=linux-usb&m=143832572328107&w=2
[2]: http://marc.info/?l=linux-usb&m=144114807421540&w=2
Peter E. Berger (6):
USB: io_ti: Remove obsolete dev parameter from build_i2c_fw_hdr
USB: io_ti: Use serial->interface for messages in download_fw
USB: io_ti: Move download and boot mode code out of download_fw
USB: io_ti: Move request_firmware from edge_startup to download_fw
USB: io_ti: Fix non-standard comment formatting
USB: io_ti: Remove extra blank lines separating functions
drivers/usb/serial/io_ti.c | 539 +++++++++++++++++++++++++--------------------
1 file changed, 304 insertions(+), 235 deletions(-)
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
