Re: [PATCH] Revert "usb: chipidea: usbmisc_imx: delete clock information"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Peter,

On Mon, Sep 14, 2015 at 11:32 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:

> This did not help.
>
> It is getting late here, so I will be able to try more things tomorrow.

I was able to fix it. Your initial patch had a missing 'return 0' in
imx_prepare_enable_clks(), causing:

clk_disable_unprepare(data->clk_ahb);
clk_disable_unprepare(data->clk_ipg);

to always be called.

Doing like this on top of your original patch:

--- a/drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/drivers/usb/chipidea/ci_hdrc_imx.c
@@ -212,6 +212,8 @@ static int imx_prepare_enable_clks(struct device *dev)
                }
        }

+       return 0;
+
 err2:
        clk_disable_unprepare(data->clk_ahb);
 err1:

, fixes the crash.

Would you like to split your patch into dts and usb parts and then
resend it formally?

Thanks,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux