2015-09-14 15:17 GMT+08:00 Peter Chen <peter.chen@xxxxxxxxxxxxx>:
> On Tue, Aug 11, 2015 at 09:43:13AM +0000, Barry Song wrote:
>> From: Rong Wang <Rong.Wang@xxxxxxx>
>>
>> Chipidea puts ci information to drvdata, but this overwrites the drvdata
>> placed by EHCI core. EHCI core thinks drvdata is ehci_hcd. We can find this
>> from codes like ehci-sysfs.c:
>> static ssize_t show_companion(struct device *dev,
>> struct device_attribute *attr,
>> char *buf)
>> {
>> struct ehci_hcd *ehci;
>>
>> ehci = hcd_to_ehci(bus_to_hcd(dev_get_drvdata(dev)));
>> ...
>> }
>>
>> So overwritting drvdata from chipidea driver actually breaks a part of
>> functionalities of EHCI core.
>>
>> Since the platform_data would not be accessed after the device is added
>> to system after the probe process, so it's safe to move to platform_data
>> here. This fix is not elegant but currently it is the quickest fix.
>
> Hi Rong,
>
> Since we have no better solution at current stage, I accept this
> solution, rebase the latest usb-next tree and make more changes please,
> then send again, thanks.
peter, i just tried and this patch was applied to the newest usb-next,
what do you mean for more changes?
-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
