Re: [PATCH] USB: option: Sierra Wireless MC73xx -> Sierra Wireless MC7304/MC7354

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 31, 2015 at 02:16:10PM -0400, David Ward wrote:
> Other Sierra Wireless MC73xx devices exist, with different USB IDs.

You should mention that you're just fixing a comment somewhere. And the
patch summary (Subject) should mention that too rather than rely on
"->".

> Cc: Bjørn Mork <bjorn@xxxxxxx>
> Signed-off-by: David Ward <david.ward@xxxxxxxxxx>
> ---
>  drivers/usb/serial/option.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 876423b..cc3e1c7 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1098,7 +1098,7 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
>  	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
>  	{ USB_DEVICE_INTERFACE_CLASS(SIERRA_VENDOR_ID, 0x68c0, 0xff),
> -	  .driver_info = (kernel_ulong_t)&sierra_mc73xx_blacklist }, /* MC73xx */
> +	  .driver_info = (kernel_ulong_t)&sierra_mc73xx_blacklist }, /* MC7304/MC7354 */
>  	{ USB_DEVICE_INTERFACE_CLASS(SIERRA_VENDOR_ID, 0x9041, 0xff),
>  	  .driver_info = (kernel_ulong_t)&sierra_mc73xx_blacklist }, /* MC7305/MC7355 */
>  	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },

This may cause some pain for people backporting PIDs due to the changed
context, but I guess that's ok.

Care to resend with an updated description?

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux