Re: [PATCH v2 2/2] usb: musb: dsps: control musb speed based on dts setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 09/09/2015 08:56 AM, Sergei Shtylyov wrote:
Hello.

On 9/9/2015 4:37 PM, Bin Liu wrote:

Set musb config->maximum_speed based on the dts setting to control musb
speed.

By default musb works in high-speed mode. Adding

    maximum-speed = "full-speed";

to dts usb node will force musb to full-speed mode.

Signed-off-by: Bin Liu <b-liu@xxxxxx>
---
  drivers/usb/musb/musb_dsps.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 65d931a..8c4b064 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -744,6 +744,20 @@ static int dsps_create_musb_pdev(struct dsps_glue
*glue,
      if (!ret && val)
          config->multipoint = true;

+    config->maximum_speed = of_usb_get_maximum_speed(dn);
+    switch (config->maximum_speed) {
+    case USB_SPEED_LOW:
+        /* fall */

    No need for this line.

Sure, I will remove it.


+    case USB_SPEED_FULL:
+        break;
+    case USB_SPEED_SUPER:
+        dev_warn(dev, "ignore incorrect maximum_speed "
+                "(super-speed) setting in dts");
+        /* fall */

    Fall thru.

Will do.

Do I have to re-send patch 1/2 in v3, since it is not revised? I am not sure about the general rules in patch submission.

Thanks,
-Bin.


+    default:
+        config->maximum_speed = USB_SPEED_HIGH;
+    }
+
      ret = platform_device_add_data(musb, &pdata, sizeof(pdata));
      if (ret) {
          dev_err(dev, "failed to add platform_data\n");

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux