Re: [PATCH 2/5] USB: io_ti: use serial->interface for messages in download_fw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 02, 2015 at 10:02:53AM +0200, Oliver Neukum wrote:
> On Tue, 2015-09-01 at 17:54 -0500, Peter E. Berger wrote:
> > From: "Peter E. Berger" <pberger@xxxxxxxxxxx>
> > 
> > Use serial->interface instead of serial->dev for messages in download_fw().
> 
> Why? The firmware is per device isn't it?
> So what sense is there in messaging about it
> at interface level?

Yeah, but the driver binds to the interface (and where there more than
one interface this code would get called twice).

I think it makes more sense to have the driver use the device it binds
to for any error or debugging messages.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux