Re: [PATCH] usb: dwc2: rename all s3c_* to dwc2_*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25.08.2015 08:30, John Youn wrote:
> On 8/18/2015 11:54 AM, Felipe Balbi wrote:
>> this driver has long ago became dwc2.ko with
>> both peripheral and host roles, there's no point
>> in keeping the old function names.
>>
>> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
>> ---
>>  arch/arm/mach-s3c64xx/mach-crag6410.c   |   4 +-
>>  arch/arm/mach-s3c64xx/mach-smartq.c     |   4 +-
>>  arch/arm/mach-s3c64xx/mach-smdk6410.c   |   4 +-
>>  arch/arm/plat-samsung/devs.c            |   6 +-
>>  drivers/usb/dwc2/core.h                 |  52 +--
>>  drivers/usb/dwc2/core_intr.c            |   4 +-
>>  drivers/usb/dwc2/debugfs.c              |  20 +-
>>  drivers/usb/dwc2/gadget.c               | 696 ++++++++++++++++----------------
>>  drivers/usb/dwc2/hcd.c                  |   4 +-
>>  drivers/usb/dwc2/platform.c             |   8 +-
>>  include/linux/platform_data/s3c-hsotg.h |  10 +-
> 
> Hi Felipe,
> 
> For dwc2/*:
> 
> Acked-by: John Youn <johnyoun@xxxxxxxxxxxx>
> Tested-by: John Youn <johnyoun@xxxxxxxxxxxx>
> 
> 
> Also, can any s3c64xx maintainers comment on this platform code?

It's the first time I see this topic. I did not receive the patch so
it's hard to comment on something I could not read. :)

> Has the dwc2 driver been used and tested on these platforms since
> becoming dwc2? I'm not sure how the driver matching is done since
> I don't see anything in the device tree and the device name seems
> to be "s3c-hsotg".
> 
> Also, are there plans to remove the usage of the platform data?

You mean since 117777b2c3b ("usb: dwc2: Move gadget probe function")
which effectively removed matching driver by device name? Probably no
one tested it. There aren't many users of s3c6410...

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux