On Sun, 23 Aug 2015, Jonas Gorski wrote:
> Commit d445913ce0ab7f ("usb: ehci-orion: add optional PHY support")
> added support for optional phys, but devm_phy_optional_get returns
> -ENOSYS if GENERIC_PHY is not enabled.
>
> This causes probe failures, even when there are no phys specified:
>
> [ 1.443365] orion-ehci f1058000.usb: init f1058000.usb fail, -38
> [ 1.449403] orion-ehci: probe of f1058000.usb failed with error -38
>
> Similar to dwc3, treat -ENOSYS as no phy.
>
> Fixes: d445913ce0ab7f ("usb: ehci-orion: add optional PHY support")
>
> Signed-off-by: Jonas Gorski <jogo@xxxxxxxxxxx>
> ---
> drivers/usb/host/ehci-orion.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
> index bfcbb9a..ee8d5fa 100644
> --- a/drivers/usb/host/ehci-orion.c
> +++ b/drivers/usb/host/ehci-orion.c
> @@ -224,7 +224,8 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
> priv->phy = devm_phy_optional_get(&pdev->dev, "usb");
> if (IS_ERR(priv->phy)) {
> err = PTR_ERR(priv->phy);
> - goto err_phy_get;
> + if (err != -ENOSYS)
> + goto err_phy_get;
> } else {
> err = phy_init(priv->phy);
> if (err)
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
