Re: [PATCH] UAS: also check for ESHUTDOWN in error reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 8/20/2015 12:16 PM, Oliver Neukum wrote:

-ESHUTDOWN means that the HC has been unplugged.
Reporting an error in that case makes no sense.

Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
---
  drivers/usb/host/xhci-ext-caps.h |  0
  drivers/usb/storage/uas.c        | 15 ++++++++-------
  2 files changed, 8 insertions(+), 7 deletions(-)
  mode change 100644 => 100755 drivers/usb/host/xhci-ext-caps.h

diff --git a/drivers/usb/host/xhci-ext-caps.h b/drivers/usb/host/xhci-ext-caps.h
old mode 100644
new mode 100755

   Say what? :-)

diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index f689219..c9a04c5 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -257,16 +257,16 @@ static void uas_stat_cmplt(struct urb *urb)
  	struct uas_cmd_info *cmdinfo;
  	unsigned long flags;
  	unsigned int idx;
+	int status = urb->status;

  	spin_lock_irqsave(&devinfo->lock, flags);

  	if (devinfo->resetting)
  		goto out;

-	if (urb->status) {
-		if (urb->status != -ENOENT && urb->status != -ECONNRESET) {
-			dev_err(&urb->dev->dev, "stat urb: status %d\n",
-				urb->status);
+	if (status) {
+		if (status != -ENOENT && status != -ECONNRESET && status != -ESHUTDOWN) {
+			dev_err(&urb->dev->dev, "stat urb: status %d\n", status);
  		}

   {} not needed here.

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux