On Tue, Aug 04, 2015 at 02:04:35PM +0000, Karajgaonkar, Saurabh (S.) wrote: > From: Saurabh Karajgaonkar <skarajga@xxxxxxxxxxx> > > Replace redundant variable use in return statement. > > Signed-off-by: Saurabh Karajgaonkar <skarajga@xxxxxxxxxxx> > --- > drivers/usb/serial/mxuport.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c > index 460a406..31a8b47 100644 > --- a/drivers/usb/serial/mxuport.c > +++ b/drivers/usb/serial/mxuport.c > @@ -1137,13 +1137,9 @@ static int mxuport_port_probe(struct usb_serial_port *port) > return err; > > /* Set interface (RS-232) */ > - err = mxuport_send_ctrl_urb(serial, RQ_VENDOR_SET_INTERFACE, > - MX_INT_RS232, > - port->port_number); > - if (err) > - return err; > - > - return 0; > + return mxuport_send_ctrl_urb(serial, RQ_VENDOR_SET_INTERFACE, > + MX_INT_RS232, > + port->port_number); I do not consider this an improvement as it makes the final ctrl-request call look different from the previous two without any real benefit. I'll drop this one. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
