Hello Yu Xu,
The patch 3d4eb9dfa3e8: "usb: gadget: mv: Add USB 3.0 device driver
for Marvell PXA2128 chip." from Jun 15, 2012, leads to the following
static checker warning:
drivers/usb/gadget/udc/mv_u3d_core.c:1668 mv_u3d_irq_process_tr_complete()
warn: 'status' can be either negative or positive
drivers/usb/gadget/udc/mv_u3d_core.c
1664 /* process the req queue until an uncomplete request */
1665 list_for_each_entry_safe(curr_req, temp_req,
1666 &curr_ep->queue, queue) {
1667 status = mv_u3d_process_ep_req(u3d, i, curr_req);
1668 if (status)
Probably if (status < 0) was intended
1669 break;
1670 /* write back status to req */
1671 curr_req->req.status = status;
^^^^^^^^
otherwise this doesn't make sense?
1672
1673 /* ep0 request completion */
1674 if (ep_num == 0) {
1675 mv_u3d_done(curr_ep, curr_req, 0);
1676 break;
1677 } else {
1678 mv_u3d_done(curr_ep, curr_req, status);
1679 }
1680 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
