On Mon, 2015-08-03 at 16:07 +0300, Mathias Nyman wrote: > From: Gavin Shan <gwshan@xxxxxxxxxxxxxxxxxx> > > When xhci_mem_cleanup() is called, it's possible that the command > timer isn't initialized and scheduled. For those cases, to delete > the command timer causes soft-lockup as below stack dump shows. > > The patch avoids deleting the command timer if it's not scheduled > with the help of timer_pending(). Are you sure this is safe? timer_pending() will not show you that the timer function is running. It looks like you introduced a race between timeout and cleanup. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html