On Mon, 10 Aug 2015, Ramneek Mehresh wrote: > > Also, what is the reason for calling usb_hcd_resume_root_hub()? It won't > > do anything, because it will run before the scheduled work, so there won't > > be a root hub for it to resume. > > > Well, you're right...it's not a surety that usb_hcd_resume_root_hub() will run after > scheduled work...i'll move it inside do_change_hcd() after usb_add_hcd(). Thanks. You're missing the point. There's no reason ever to call usb_hcd_resume_root_hub() immediately after usb_add_hcd(). The hub driver does everything necessary when the root hub is registered. Resuming it (if it is suspended at that point) won't accomplish anything because all the important work has just been done. Now, if you _weren't_ calling usb_add_hcd() (for example if host.is_otg were 0) then it might make sense to call usb_hcd_resume_root_hub() -- although I don't see why you would need to. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
