Re: [PATCH 4/9] usb: host: ehci-st: Simplify return statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On 08/04/2015 11:10 AM, Karajgaonkar, Saurabh (S.) wrote:
From: Saurabh Karajgaonkar <skarajga@xxxxxxxxxxx>

Replace redundant variable use in return statement.

Signed-off-by: Saurabh Karajgaonkar <skarajga@xxxxxxxxxxx>
---
  drivers/usb/host/ehci-st.c | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
index 7e4bd39..b7c5cfa 100644
--- a/drivers/usb/host/ehci-st.c
+++ b/drivers/usb/host/ehci-st.c
@@ -54,7 +54,6 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd)
  	struct platform_device *pdev = to_platform_device(hcd->self.controller);
  	struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev);
  	struct ehci_hcd *ehci = hcd_to_ehci(hcd);
-	int retval;
  	u32 threshold;
/* Set EHCI packet buffer IN/OUT threshold to 128 bytes */
@@ -62,11 +61,7 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd)
  	writel(threshold, hcd->regs + AHB2STBUS_INSREG01);
ehci->caps = hcd->regs + pdata->caps_offset;
-	retval = ehci_setup(hcd);
-	if (retval)
-		return retval;
-
-	return 0;
+	return ehci_setup(hcd);
  }
static int st_ehci_platform_power_on(struct platform_device *dev)


Acked-by: Patrice Chotard <patrice.chotard@xxxxxx>

Thanks

Patrice
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux