Re: [PATCH] USB: ftdi_sio: Added custom PID for CustomWare products

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2015-08-03 00:07, Matthijs Kooijman wrote:
Hi Lars,

thanks for your feedback.

+	{ USB_DEVICE(FTDI_VID, FTDI_CUSTOMWARE_MINIPLEX_PID) },
+	{ USB_DEVICE(FTDI_VID, FTDI_CUSTOMWARE_MINIPLEX2_PID) },
+	{ USB_DEVICE(FTDI_VID, FTDI_CUSTOMWARE_MINIPLEX2WI_PID) },
+	{ USB_DEVICE(FTDI_VID, FTDI_CUSTOMWARE_MINIPLEX3_PID) },

Please sort in alphabetic order.
Do you mean to sort these four entries relative to each other? They
already look sorted to me (though if you insist on using ASCII values
for sorting, _ would sort after 2, 3 and W and the order would somewhat
change). Or do you mean to move all four entries to a different place in
the file?

Gr.

Matthijs

What I meant is that ...FTDI_C..... should come before ...FTDI_S.... and not after, but I've had a look at the whole ftdi_sio.c source now and it looks horrible.
I think it doesn't really matter where you put your additions, do as
others has done and put them at a random position..

greets
Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux