Re: [PATCH v9 4/4] USB: io_ti: Add heartbeat to keep idle EP/416 ports from disconnecting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2015-07-31 at 12:21 +0200, Johan Hovold wrote:
> On Fri, Jul 31, 2015 at 01:55:08AM -0500, Peter E. Berger wrote:
> > From: "Peter E. Berger" <pberger@xxxxxxxxxxx>
> > 
> > When using Edgeport/416 models with newer firmware (sometime after
> > firmware version 4.80.0), idle ports are automatically bounced
> > (disconnected and then reconnected) approximately every 60 seconds.
> > This breaks programs (e.g: minicom) where idle periods are common,
> > normal and expected.
> > 
> > I confirmed with the manufacturer (Digi International) that Edgeport/416
> > models now ship from the factory with firmware that expects periodic
> > "heartbeat" queries from the driver to keep idle ports alive.  This
> > patch implements heartbeat support using the mechanism Digi suggested
> > (periodically requesting an I2C descriptor address) that appears effective
> > on Edgeports running the newer firmware (that require it) and benign on
> > Edgeport devices running older firmware.  Since we know that Edgeport
> > firmware version 4.80 (the version distributed in /lib/firmware/down3.bin
> > and used for Edgeports that are either running still older versions or
> > have no onboard non-volatile firmware image) does not require heartbeat
> > support, this patch schedules heartbeats only on Edgeport/416 devices,
> > and only if they are running firmware versions newer than 4.80.
> > 
> > Signed-off-by: Peter E. Berger <pberger@xxxxxxxxxxx>
> 
> All now applied for 4.3 (this one with some really minor style changes).

Wonderful!  Thanks so much to you, Sergei, Oliver and Don for all your
thoughtful comments and patience in helping me get these patches into
shape.

Best regards,
     --Peter
> 
> Thanks again for fixing this!
> 
> Johan


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux