On Thu, Jul 30, 2015 at 10:28:05AM -0500, Peter Berger wrote:
> On Thu, 2015-07-30 at 15:44 +0200, Johan Hovold wrote:
> > On Wed, Jul 22, 2015 at 01:56:14PM -0500, Peter E. Berger wrote:
> > > From: "Peter E. Berger" <pberger@xxxxxxxxxxx>
> > > @@ -943,6 +944,17 @@ static int download_fw(struct edgeport_serial *serial)
> > > struct usb_interface_descriptor *interface;
> > > int download_cur_ver;
> > > int download_new_ver;
> > > + struct edgeport_fw_hdr *fw_hdr = (struct edgeport_fw_hdr *)fw->data;
> > > +
> > > + if (fw->size < sizeof(struct edgeport_fw_hdr)) {
> >
> > Missing le16_to_cpu on fw->size.
>
> Hmmm... The fw->size refers to the "size_t size" element of struct
> firmware (not to an element of edgeport_fw_hdr). Are you saying that I
> should change this to "if (le16_to_cpu(fw->size) < sizeof..." or did I
> mistake your meaning?
My bad, I read it as fw_hdr->length. Sorry about that.
> I'll work on this and the other changes when I get back tonight and hope
> to have a new patchset for you by tomorrow.
Much appreciated.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
