On Wed, Jul 22, 2015 at 01:56:16PM -0500, Peter E. Berger wrote:
> +static inline void edge_heartbeat_schedule(struct edgeport_serial *edge_serial)
> +{
> + u16 product_id = le16_to_cpu(
> + edge_serial->serial->dev->descriptor.idProduct);
> +
> + /* Currently only the EP/416 models require heartbeat support */
> + if (product_id != ION_DEVICE_ID_TI_EDGEPORT_416 &&
> + product_id != ION_DEVICE_ID_TI_EDGEPORT_416B)
> + return;
> +
> + if (edge_serial->fw_version <= FW_HEARTBEAT_VERSION_CUTOFF)
> + return;
Please do both these checks (product id and fw_version) once in
edge_startup and just set a flag in struct edgeport_serial (e.g. bool
use_heartbeat) that you check here.
> +
> + schedule_delayed_work(&edge_serial->heartbeat_work,
> + FW_HEARTBEAT_SECS * HZ);
> +}
This series looks really good now. Care to fix these last few issues up
and I'll apply it for 4.3 in the next couple of days?
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
