On 20/07/15 04:23, Peter Chen wrote:
> On Fri, Jul 17, 2015 at 01:47:12PM +0300, Roger Quadros wrote:
>>>> + * DRD mode hardware Inputs
>>>> + *
>>>> + * @id: TRUE for B-device, FALSE for A-device.
>>>> + * @vbus: VBUS voltage in regulation.
>>>> + *
>>>> * OTG hardware Inputs
>>>> *
>>>> * Common inputs for A and B device
>>>> @@ -122,7 +127,8 @@ enum otg_fsm_timer {
>>>> */
>>>> struct otg_fsm {
>>>> /* Input */
>>>> - int id;
>>>> + int id; /* DRD + OTG */
>>>> + int vbus; /* DRD only */
>>>
>>> Existing b_sess_vld can be also used for drd only case, no need create
>>> a new flag.
>>
>> b_sess_vld is a bit confusing to people not familiar with OTG.
>> My suggestion is to use dedicated 'vbus' flag for DRD case
>> for simplicity.
>>
>
> Since OTG DRD is the subset in OTG FSM (FSM, data structure, APIs, etc),
> I agree with Jun to reuse existing variables, and we can add some comments
> for b_sess_vld if needed.
OK then. I'll get rid of vbus and use b_sess_vld.
cheers,
-roger
>
>
>>>
>>>> int adp_change;
>>>> int power_up;
>>>> int a_srp_det;
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
