On Mon, Jul 20, 2015 at 03:38:17PM -0500, Felipe Balbi wrote: > On Mon, Jul 20, 2015 at 05:36:34PM -0300, Fabio Estevam wrote: > > On Mon, Jul 20, 2015 at 5:09 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > > We have a "Enabling %s" trace when enabling an endpoint > > > but that message felt lonely without a matching > > > "Disabling %s". Add it. > > > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > > --- > > > drivers/usb/dwc3/gadget.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > > index 333a7c0078fc..7f6498dc30f2 100644 > > > --- a/drivers/usb/dwc3/gadget.c > > > +++ b/drivers/usb/dwc3/gadget.c > > > @@ -586,6 +586,8 @@ static int __dwc3_gadget_ep_disable(struct dwc3_ep *dep) > > > struct dwc3 *dwc = dep->dwc; > > > u32 reg; > > > > > > + dwc3_trace(trace_dwc3_gadget, "Enabling %s", dep->name); > > > + > > > > I think you meant "Disabling" :-) > > yeah, I did :-) Thanks here's updated version: 8<---------------------------------------------------------------------- From 2a87b731fedbb018b7330b79fb4d8bff5349d4b4 Mon Sep 17 00:00:00 2001 From: Felipe Balbi <balbi@xxxxxx> Date: Mon, 20 Jul 2015 14:46:15 -0500 Subject: [PATCH 1/2] usb: dwc3: gadget: add a trace when disabling EPs We have a "Enabling %s" trace when enabling an endpoint but that message felt lonely without a matching "Disabling %s". Add it. Signed-off-by: Felipe Balbi <balbi@xxxxxx> --- drivers/usb/dwc3/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 333a7c0078fc..1f8f730c7cc5 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -586,6 +586,8 @@ static int __dwc3_gadget_ep_disable(struct dwc3_ep *dep) struct dwc3 *dwc = dep->dwc; u32 reg; + dwc3_trace(trace_dwc3_gadget, "Disabling %s", dep->name); + dwc3_remove_requests(dwc, dep); /* make sure HW endpoint isn't stalled */ -- 2.4.4 -- balbi
Attachment:
signature.asc
Description: Digital signature
