RE: [PATCH/RFC] usb: gadget: udc: core: Fix argument of dma_map_single for IOMMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

> Sent: Tuesday, July 14, 2015 1:52 AM
> 
> Hi Greg,
> 
> On Mon, Jul 13, 2015 at 6:19 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, Jul 13, 2015 at 06:10:05PM +0900, Yoshihiro Shimoda wrote:
> >> The dma_map_single and dma_unmap_single should set "gadget->dev.parent"
> >> instead of "&gadget->dev" in the first argument because the parent has
> >> a udc controller's device pointer.
> >> Otherwise, iommu functions are not called in ARM environment.
> >>
> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> >> ---
> >>  This patch is based on the Felipe's usb.git / testing/next branch.
> >>  commit id = 298623983e74d935fc241d0eb1d0740cf4c32599
> >
> > Why send something that has already been accepted into Felipe's tree?
> 
> That commit ID does not refer to Shimoda-san's patch, but to the HEAD of
> Felipe's testing/next branch.

Thank you for your comment! I meant that.
(I'm sorry for my lack explanation.)

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux