Re: [PATCH v3 05/11] usb: hcd.h: Add OTG to HCD interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 08, 2015 at 01:19:31PM +0300, Roger Quadros wrote:
> The OTG core will use struct otg_hcd_ops to
> add/remove the HCD controller.
> 
> The main purpose of this interface is to avoid directly
> calling usb_add/remove_hcd() from the OTG core as they
> wouldn't be defined in the built-in symbol table if
> CONFIG_USB is m.
> 

Like patch 4, Would you let the OTG depends on HCD?
OTG needs dual-role, it is reasonable.

Peter

> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
> ---
>  include/linux/usb/hcd.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c9aa779..4108288 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -386,6 +386,20 @@ struct hc_driver {
>  
>  };
>  
> +/**
> + * struct otg_hcd_ops - Interface between OTG core and HCD
> + *
> + * Provided by the HCD core to allow the OTG core to start/stop the HCD
> + *
> + * @add: function to add the HCD
> + * @remove: function to remove the HCD
> + */
> +struct otg_hcd_ops {
> +	int (*add)(struct usb_hcd *hcd,
> +		   unsigned int irqnum, unsigned long irqflags);
> +	void (*remove)(struct usb_hcd *hcd);
> +};
> +
>  static inline int hcd_giveback_urb_in_bh(struct usb_hcd *hcd)
>  {
>  	return hcd->driver->flags & HCD_BH;
> -- 
> 2.1.4
> 

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux