On 07/08/2015 02:11 AM, Hans de Goede wrote:
Hi,
On 07-07-15 18:47, Jeremy White wrote:
Well, the checkpatch.pl reports were all style (and mostly whitespace);
roughly 3000 of them against 3000 lines of code :-/. I did review the
code, looking for areas where I thought it would badly cram into the
kernel, and I adjusted the few I found (and sent changes upstream).
style matters, as it's a thing with your brain. You learn patterns and
if the patterns change, you have to do more work and don't see the real
issues involved. So by ignoring our style you are saying you don't want
anyone else in the kernel community to ever review or work on the code,
which isn't ok.
Looks like I can't side step this unless Hans is willing to shift the
usbredir project entirely to using kernel style :-/.
I'm fine with moving the usbredir project to the kernel style, the question
is how to do this without causing any hidden breakage.
Can you create a gnu-indent invocation which will do most of the work?
And then a hopefully managable sized patch on top to fix the remaining
style errors in usbredirparser ?
Got it; that's a helpful surprise. I'll work on patches for all but the
whitespace, for only the files needed. I'm hoping whitespace changes
can be limited to a gnu-indent invocation at patch transfer time. I'd
hate to destroy the history like that :-/.
Cheers,
Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
