Re: Re: [USB][OHCI]BugFix:Insert new ed at end of ohci->ed_rm_list to accomdate race condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 8 Jul 2015, AMAN DEEP wrote:

> >Your analysis is correct, but I don't like the solution.  The code you 
> >quoted above uses *last after finish_urb(), which is not a good idea.
> >
> >In my opinion, it would be better to go back to the way things were 
> >before commit 977dcfdc6031 and remove ed from the ed_rm_list before 
> >finishing any URBs.  Then at the end, we can add ed back to the list 
> >if necessary.
> >
> >How does the patch below look to you?  Does it fix the problem?
> 
> yes, this change is also doing the same which i wanted to do.
> I think it is better way of implementing the required change.
> 
> Should i submit the changed patch for required change ?

Sure, go ahead.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux