On Wed, Jul 08 2015, Robert Baldyga wrote: > Function midi registers two interfaces with single set_alt() function > which means that f_midi_set_alt() is called twice when configuration > is set. That means that endpoint initialization and ep request allocation > is done two times. To avoid this problem we do such things only once, > for interface number 1 (MIDI Streaming interface). > > Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx> > --- > drivers/usb/gadget/function/f_midi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index 6316aa5..4cef222 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -329,6 +329,10 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt) > unsigned i; > int err; > > + /* For Control Device interface we do nothing */ > + if (intf == 0) > + return 0; > + > err = f_midi_start_ep(midi, f, midi->in_ep); > if (err) > return err; > -- > 1.9.1 > -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
