Re: [PATCH] usb: gadget: dummy_hcd: check hcd at urb enqueue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alan,
On Tue, Jul 07, 2015 at 02:07:48PM -0400, Alan Stern wrote:
On Tue, 7 Jul 2015, Rui Miguel Silva wrote:

When processing urb list in dummy_timer and an ep goes away, the urb
is giveback with an -EPROTO error. However the same urb can be
enqueued once again and the loop in dummy_timer never get out.

I don't understand.  Why would dummy_timer behave differently for the
second URB submission?  It should follow the same logic and return
-EPROTO just like the first time.

To fix that, make sure the dummy_hcd is enabled at enqueue time to
avoid adding urb to the urbp list.
To fix that, make sure the dummy_hcd is enabled at enqueue time to
avoid adding urb to the urbp list.

This is not the right approach.  We want to allow URBs to be enqueued
even if the device's upstream port is not enabled.  After all, real
HCDs allow this.

Yes, you are right. Just drop this patch. Sorry for the noise.

Cheers,
   Rui

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux