On Thu, Jul 02, 2015 at 09:12:30PM +0200, Krzysztof Opasiak wrote: > > > On 07/02/2015 07:16 PM, Michal Nazarewicz wrote: > >>On 07/02/2015 05:25 PM, Michal Nazarewicz wrote: > >>>Since I think we agreed that luns should just be turned into an array > >>>with static length the above won’t be too far from that goal. > > > >On Thu, Jul 02 2015, Krzysztof Opasiak wrote: > >>True, just started working on it. > > > >I just got this to compile but haven’t tested it past that. Feel free > >to grab it or whatever: > > > > Ohh, I was quite busy with testing (and debugging) my patches and didn't > notice this message, sorry... > > I have run through this patch and didn't find any serious issues. > But in my opinion instead of editing set_nluns() we could simply drop it and > simplify legacy gadgets code as we do almost nothing in this function. for the -rc cycle we need a minimal fix, though. Simplification, refactoring and whatever else, needs to be merged during merge window. -- balbi
Attachment:
signature.asc
Description: Digital signature
