Re: [PATCH 3/7] usb: dwc3: keystone: convert dev_dbg() to dev_err()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 01, 2015 at 12:12:05AM +0300, Sergei Shtylyov wrote:
> On 07/01/2015 12:10 AM, Felipe Balbi wrote:
> 
> >>>that's an error condition, not a debugging message.
> 
> >>>Let's promote it appropriately.
> 
> >>>Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> >>>---
> >>>  drivers/usb/dwc3/dwc3-keystone.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> >>>diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
> >>>index fe3b9335a74e..c1ca2a0a56ef 100644
> >>>--- a/drivers/usb/dwc3/dwc3-keystone.c
> >>>+++ b/drivers/usb/dwc3/dwc3-keystone.c
> >>>@@ -115,7 +115,7 @@ static int kdwc3_probe(struct platform_device *pdev)
> >>>
> >>>  	error = clk_prepare_enable(kdwc->clk);
> >>>  	if (error < 0) {
> >>>-		dev_dbg(kdwc->dev, "unable to enable usb clock, err %d\n",
> >>>+		dev_err(kdwc->dev, "unable to enable usb clock, err %d\n",
> 
> >>    Perhaps time to s/err/error/?
> 
> >what do you mean ? There's a dev_error now ? Can't seem to find it with
> >grep.
> 
>    I meant "err" in the message. :-)

oh, haha, I was completely blind to that. I'll fix it in my branch
(testing/next) Thanks.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux