On Tue, 30 Jun 2015, Sergei Shtylyov wrote:
> Hello.
>
> On 06/30/2015 06:25 PM, Alan Stern wrote:
>
> > This patch fixes a bug introduced by commit 977dcfdc6031 ("USB: OHCI:
> > don't lose track of EDs when a controller dies"). The commit changed
> > ed_state from ED_UNLINK to ED_IDLE too early, before finish_urb() had
> > been called. The user-visible consequence is that the driver
> > occasionally crashes or locks up when an URB is submitted while
> > another URB for the same endpoint is being unlinked.
>
> > This patch moves the ED state change later, to the right place. The
> > drawback is that now we may unnecessarily execute some instructions
> > multiple times when a controller dies. Since controllers dying is an
> > exceptional occurrence, a little wasted time won't matter.
> >
> > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Reported-by: Heiko Przybyl <lil_tux@xxxxxx>
> > Tested-by: Heiko Przybyl <lil_tux@xxxxxx>
> > Fixes: 977dcfdc60311e7aa571cabf6f39c36dde13339e
>
> Documentation/SubmittingPatches says to use 12-digit SHA1 and the summary
> after it enclosed in ("").
Yes, you're right. I did it that way in the first two lines of the
body of the patch description but not in the Fixes: tag. Greg can
alter the text of the tag (by copying the reference in the body) if he
wants.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
