On Tue, Jun 30, 2015 at 12:56:50PM -0500, Felipe Balbi wrote: > now that we have no users of dev_dbg() in dwc3, > we can't safely remove CONFIG_USB_DWC3_DEBUG. > > If dev_dbg() is ever strictly necessary - and I > don't see why it would, considering we want to > rely on tracepoints for debug - we will depend > on DYNAMIC_PRINTK to enable such messages. > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > --- > drivers/usb/dwc3/Kconfig | 9 --------- > drivers/usb/dwc3/Makefile | 2 -- > 2 files changed, 11 deletions(-) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index dede32e809b6..cdd3eae604af 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -103,12 +103,3 @@ config USB_DWC3_QCOM > help > Recent Qualcomm SoCs ship with one DesignWare Core USB3 IP inside, > say 'Y' or 'M' if you have one such device. > - > -comment "Debugging features" > - > -config USB_DWC3_DEBUG > - bool "Enable Debugging Messages" > - help > - Say Y here to enable debugging messages on DWC3 Driver. > - > -endif argh, of course I sent the wrong version :-) Here's the correct one 8<------------------------------------------------------------------ From 775881f78c796a8988943ad3c487de38a18bd94f Mon Sep 17 00:00:00 2001 From: Felipe Balbi <balbi@xxxxxx> Date: Tue, 30 Jun 2015 12:51:49 -0500 Subject: [PATCH v2 7/7] usb: dwc3: drop CONFIG_USB_DWC3_DEBUG now that we have no users of dev_dbg() in dwc3, we can't safely remove CONFIG_USB_DWC3_DEBUG. If dev_dbg() is ever strictly necessary - and I don't see why it would, considering we want to rely on tracepoints for debug - we will depend on DYNAMIC_PRINTK to enable such messages. Signed-off-by: Felipe Balbi <balbi@xxxxxx> --- changes since v1 - fix erroneous removal of endif drivers/usb/dwc3/Kconfig | 7 ------- drivers/usb/dwc3/Makefile | 2 -- 2 files changed, 9 deletions(-) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index dede32e809b6..5a42c4590402 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -104,11 +104,4 @@ config USB_DWC3_QCOM Recent Qualcomm SoCs ship with one DesignWare Core USB3 IP inside, say 'Y' or 'M' if you have one such device. -comment "Debugging features" - -config USB_DWC3_DEBUG - bool "Enable Debugging Messages" - help - Say Y here to enable debugging messages on DWC3 Driver. - endif diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile index c7076e37c4ed..acc951d46c27 100644 --- a/drivers/usb/dwc3/Makefile +++ b/drivers/usb/dwc3/Makefile @@ -1,8 +1,6 @@ # define_trace.h needs to know how to find our header CFLAGS_trace.o := -I$(src) -ccflags-$(CONFIG_USB_DWC3_DEBUG) := -DDEBUG - obj-$(CONFIG_USB_DWC3) += dwc3.o dwc3-y := core.o debug.o trace.o -- 2.4.4 -- balbi
Attachment:
signature.asc
Description: Digital signature
