Re: [EDT][PATCH] XHCI: Fix memory leak in error condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26/06/15 10:46, Vivek Kumar Bhagat wrote:
EP-EC562D6B53594479BCA6FC73F17DEE54
In error condition, td buffer is not freed which can lead
to memory leak.

Signed-off-by: Vivek Kumar Bhagat <vivek.bhagat@xxxxxxxxxxx>
---
  drivers/usb/host/xhci.c |    1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 36bf089..dc02532 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -1438,6 +1438,7 @@ dying:
  	ret = -ESHUTDOWN;
  free_priv:
  	xhci_urb_free_priv(urb_priv);
+	kfree(buffer);
  	urb->hcpriv = NULL;
  	spin_unlock_irqrestore(&xhci->lock, flags);
  	return ret;


Do you need to fix up xhci_urb_free_priv() as well?

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux