On Wed, Jun 24, 2015 at 12:39:05AM -0500, Peter Berger wrote: > On Mon, 2015-06-22 at 10:45 +0200, Johan Hovold wrote: > > On Thu, Jun 18, 2015 at 06:43:34AM -0500, Peter E. Berger wrote: > > > From: "Peter E. Berger" <pberger@xxxxxxxxxxx> > > > > > > The io_ti driver fails to download firmware to Edgeport devices such as > > > the EP/416. One of the problems is that the default 1 second timeout > > > in ti_vsend_sync() is insufficient for download operations. This patch > > > increases the download timeout to 10 seconds. > > > > Patch looks good now. > > > > What happens when download fails? Does the device still work (e.g. this > > is only needed to support newer on-disk firmware)? Perhaps you can > > mention that in the commit log as well. > > It looks like some Edgeports (models like the EP/416 with on-board > E2PROM) may be able to function even if the on-disk firmware image is > bad or missing, iff their local E2PROM versions are valid. But most > Edgeport models (I've tried EP/1 and EP/4) do not appear to have this > capability and they always rely on the on-disk firmware image. > > I'm testing an implementation that calls the new check_fw_sanity() > function at the top of download_fw() and, rather than simply returning > an error if the firmware image is bad or missing, it saves the result > and defers the decision until later when it may find that it is running > on a E2PROM-equipped device with a valid image. But I think this is > messier than it is worth (adding still more messiness to the already > very messy download_fw()) for such a marginal possible benefit. I'm > leaning towards the simpler approach of returning an error whenever > check_fw_sanity() indicates a bad on-disk firmware image. Do you agree? Yes, that sounds reasonable. Perhaps such a feature can be added later after a much-needed clean up of download_fw, if ever. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
