On Tue, Jun 23, 2015 at 02:25:06PM +0200, Uwe Kleine-König wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. > > Use this additional parameter and the _optional variant to simplify the > driver and improve error handling. Also expand the comment to explain > why it's not sensible to switch to devm_gpiod_get and why the gpiod_put > is also necessary. > > Furthermore this is one caller less that stops us making the flags > argument to gpiod_get*() mandatory. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Tested-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html