Re: [PATCH RESEND (1-3)/4] Add usb interface authorization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stefan,

On Tue, Jun 9, 2015 at 6:38 PM, Stefan Koch <stefan.koch10@xxxxxxxxx> wrote:
> Am Dienstag, den 09.06.2015, 07:49 -0700 schrieb Greg KH:
>> On Tue, Jun 09, 2015 at 03:48:47PM +0200, Stefan Koch wrote:
>> > Am Montag, den 08.06.2015, 07:40 -0700 schrieb Greg KH:
>> > > On Mon, Jun 08, 2015 at 03:24:26PM +0200, Stefan Koch wrote:

<..snip..>

>> > >
>> > > Care to resend this in a format that it could be applied in (i.e. broken
>> > > up into logical chunks with the proper Signed-off-by: lines)?
>> > >
>> > > As this is, there's nothing we can do with it.
>> > >
>> > > thanks,
>> > >
>> > > greg k-h
>> >
>> > Hi
>> >
>> > I think whitespaces should be ok now. I have tested now three mail
>> > clients...
>> >
>> > This patch series enables the interface authorization. The description
>> > is improved now. Is the series correct now?
>>
>> I need these in a one-patch-per-email format, with the subject fixed up.
>> These need to be in a format where I don't have to edit anything in the
>> email by hand in order to apply them, that hasn't happened yet :(
>>
>> thanks,
>>
>> greg k-h
>
> Do you mean this should like the patches 1/4 2/4 3/4 4/4 with the wrong
> whitspaces?
>
> Should the patch mail not include any text like Hi and thanks and so on?

Could you please read and check Documentation/SubmittingPatches?
It gives answers on some of you questions. Chapter 14 "The canonical
patch format" will help.

Please also don't forget to run checkpatch.pl. I see some bad style
comments in one of your patches.

Well, you can add "Hi" to [PATCH 0/12] email, for example.

-- 
Best regards,
Alexey Klimov
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux