Re: [PATCH v2 3/4] usb: gadget: move common storage gadget structure to header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 08 2015, snjsrwt wrote:
> On 6/8/2015 1:33 PM, Michal Nazarewicz wrote:
>> On Mon, Jun 08 2015, Sanjay Singh Rawat wrote:
>>> struct fsg_common is used in multiple files, moving it to header
>>> file from the source file.
>> Isn’t this patch a prerequisit for the previous patch?  Just merge them
>> together.
>
> Yes right, actually patch-3 is prerequisite for both 2 & 4 (I just 
> wanted to break the changes to
> small logical units). Should i club all 3 together?

Yeah, let’s just do that.

Furthermore, you might consider renaming fsg_common_run_thread to
fsg_common_create_thread.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux