On Fri, May 29, 2015 at 11:15:51AM -0300, Rodrigo Severo wrote: > On Fri, May 29, 2015 at 11:01 AM, Mathias Nyman > <mathias.nyman@xxxxxxxxxxxxxxx> wrote: > > Now including Renesas uPD720201 we got four xhci vendors that return > > Success instead of short transfer when there are still unstraferred bytes > > left. The driver anyway checks the untransferred bytes and suggest adding > > the quirk if needed, so we can as well make it default behavior and get > > rid of the quirk all together. > > > > Cc: Rodrigo Severo <rodrigo@xxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> > > --- > > drivers/usb/host/xhci-pci.c | 3 --- > > drivers/usb/host/xhci-ring.c | 22 ++++++++++------------ > > drivers/usb/host/xhci.h | 2 -- > > 3 files changed, 10 insertions(+), 17 deletions(-) > > > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > > index 4a4cb1d..3ebf182 100644 > > --- a/drivers/usb/host/xhci-pci.c > > +++ b/drivers/usb/host/xhci-pci.c > > @@ -103,7 +103,6 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) > > "QUIRK: Fresco Logic revision %u " > > "has broken MSI implementation", > > pdev->revision); > > - xhci->quirks |= XHCI_TRUST_TX_LENGTH; > > } > > > > if (pdev->vendor == PCI_VENDOR_ID_NEC) > > @@ -117,7 +116,6 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) > > xhci->quirks |= XHCI_AMD_PLL_FIX; > > > > if (pdev->vendor == PCI_VENDOR_ID_AMD) > > - xhci->quirks |= XHCI_TRUST_TX_LENGTH; > > You should remove the whole "if" statement here, not only the > XHCI_TRUST_TX_LENGTH setting. Ah, but we want an if statement that will never be true :) Good catch, Mathias, can you fix this up and resend it? I'll drop it from my queue. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
