Re: [PATCH 01/11] usb: phy: return error on failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 05, 2015 at 04:14:35PM +0200, Mian Yousaf Kaukab wrote:
> If the requested phy operation can't be done, return error instead of
> success to let the caller know.
> 
> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@xxxxxxxxx>
> ---
>  include/linux/usb/phy.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
> index bc91b5d..d2b03db 100644
> --- a/include/linux/usb/phy.h
> +++ b/include/linux/usb/phy.h
> @@ -262,7 +262,7 @@ usb_phy_set_power(struct usb_phy *x, unsigned mA)
>  {
>  	if (x && x->set_power)
>  		return x->set_power(x, mA);
> -	return 0;
> +	return -EOPNOTSUPP;

the idea is that these operations are actually optional, so it's ok to
return 0.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux