Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 22 May 2015 19:22:47 CEST, Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx> wrote:
>On Fri, 2015-05-22 at 13:15 +0200, Bjørn Mork wrote:
>> The tx_curr_frame_payload field is u32. When we try to calculate a
>> small negative delta based on it, we end up with a positive integer
>> close to 2^32 instead.  So the tx_bytes pointer increases by about
>> 2^32 for every transmitted frame.
>> 
>> Fix by calculating the delta as a signed long.
>
>Told you I hadn't tested it.


Yes, I know. This was all my bad. Sorry. Didn't mean to imply that you were to blame here. On the contrary. Thanks again for showing how to solve this.


Bjørn

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux