Hello Andrzej Pietrasiewicz,
The patch d6d22922d907: "usb: gadget: rndis: remove the limit of
available rndis connections" from Feb 6, 2015, leads to the following
static checker warning:
drivers/usb/gadget/function/rndis.c:881 rndis_register()
warn: impossible condition '(i < 0) => (0-255 < 0)'
drivers/usb/gadget/function/rndis.c
872 struct rndis_params *rndis_register(void (*resp_avail)(void *v), void *v)
873 {
874 struct rndis_params *params;
875 u8 i;
876
877 if (!resp_avail)
878 return ERR_PTR(-EINVAL);
879
880 i = rndis_get_nr();
881 if (i < 0) {
^^^^^
i is unsigned. I think it needs to be int to hold the high values as
well. This file has a bunch of compile warnings in linux-next.
882 pr_debug("failed\n");
883
884 return ERR_PTR(-ENODEV);
885 }
886
887 params = kzalloc(sizeof(*params), GFP_KERNEL);
888 if (!params) {
889 rndis_put_nr(i);
890
891 return ERR_PTR(-ENOMEM);
892 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
