Re: [PATCH v2] usb: gadget: ether: Fix MAC address parsing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stefan Agner <stefan@xxxxxxxx> writes:

> I agree that using a common implementation makes sense, however that
> implementation does not support the central idea of that patch:
> supporting the standard format which is created by libc's
> ether_ntoa_r...

"standard" format, at best.  I cannot think of a single commonly used
Linux tool actually using that format.  Most people just use the proper
format string...  Do you have an example of source code using
ether_ntoa_r() (or ether_ntoa)?

In any case, adding parser complexity in the kernel just to accommodate
some rarely used userspace library function, which is easily and usually
replaced by a printf anyway, seems utterly pointless.

If you are still going to do this, then please justify the change for
the mac_pton() function.  There are zilch reasons why mac parsing in the
usb subsystem should be different from the rest of the kernel.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux