On Wed, May 13, 2015 at 6:36 PM, Rodrigo Severo <rodrigo@xxxxxxxxxxxxxxxxxxx> wrote: > Activating XHCI_TRUST_TX_LENGTH on Renesas uPD720201 USB 3.0 hosts to get rid of > the following warnings when using webcams on this type of host: > > xhci_hcd 0000:06:00.0: WARN Successful completion on short TX: needs > XHCI_TRUST_TX_LENGTH quirk? > > Signed-off-by: Rodrigo Severo <rodrigo@xxxxxxxxxxxxxxxxxxx> When sending a second version of the patch you should mark [PATCH v2] in the Subject. And you can drop the 'corrected' marking. Also you need to explain what changed in v2 compared to the previous version below the --- line. > --- > drivers/usb/host/xhci-pci.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c > index b02641b..63a2d17 100644 > --- a/drivers/usb/host/xhci-pci.c > +++ b/drivers/usb/host/xhci-pci.c > @@ -43,6 +43,7 @@ > > #define PCI_DEVICE_ID_ASMEDIA_ASM1042A 0x1142 > > +#define PCI_DEVICE_ID_RENESAS_UPD720201 0x0014 > #define PCI_DEVICE_ID_RENESAS_UPD720202 0x0015 > > static const char hcd_name[] = "xhci_hcd"; > @@ -173,13 +174,14 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) > xhci->quirks |= XHCI_TRUST_TX_LENGTH; > } > > + if (pdev->vendor == PCI_VENDOR_ID_RENESAS && > + (pdev->device == PCI_DEVICE_ID_RENESAS_UPD720201 || > + pdev->device == PCI_DEVICE_ID_RENESAS_UPD720202)) > + xhci->quirks |= XHCI_TRUST_TX_LENGTH; > + > if (xhci->quirks & XHCI_RESET_ON_RESUME) > xhci_dbg_trace(xhci, trace_xhci_dbg_quirks, > "QUIRK: Resetting on resume"); > - > - if (pdev->vendor == PCI_VENDOR_ID_RENESAS && > - pdev->device == PCI_DEVICE_ID_RENESAS_UPD720202) > - xhci->quirks |= XHCI_TRUST_TX_LENGTH; > } You are also moving the 'if' prior to the XHCI_RESET_ON_RESUME test. Is this needed? If so, it should be a separate patch. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
