Hello Mian Thanks for your patches. I applied the last 10 on my tree and tested them with g_mass_storage. It works ok, but there are some error messages that I attach. The error messages were also there before your patches were applied so I guess it is fine :) mass_storage usb3.0 (75 MB/s/12MB/s) after patches [ 74.436098] Number of LUNs=8 [ 74.436119] Mass Storage Function, version: 2009/09/11 [ 74.436128] LUN: removable file: (no medium) [ 74.436144] Number of LUNs=1 [ 74.436306] LUN: file: /var/volatile/tmp/kk [ 74.436313] Number of LUNs=1 [ 74.436484] g_mass_storage gadget: Mass Storage Gadget, version: 2009/09/11 [ 74.436493] g_mass_storage gadget: userspace failed to provide iSerialNumber [ 74.436498] g_mass_storage gadget: g_mass_storage ready [ 74.436564] net2280 0000:03:00.0: Operate Defect 7374 workaround soft this time [ 74.436570] net2280 0000:03:00.0: It will operate on cold-reboot and SS connect [ 88.048058] net2280 0000:03:00.0: INFO: Defect 7374 workaround waited about [ 88.048058] 0uSec for Control Read Data Phase ACK [ 88.053175] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 89.055470] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 89.287856] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 89.288197] net2280 0000:03:00.0: The dmastat return = 5002!! [ 89.296769] net2280 0000:03:00.0: net2280_queue: error=-95 [ 89.298411] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 89.403098] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 89.505129] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 89.735988] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 89.736341] net2280 0000:03:00.0: The dmastat return = 5002!! [ 89.741279] net2280 0000:03:00.0: net2280_queue: error=-95 [ 89.745614] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 89.848666] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 89.951129] net2280 0000:03:00.0: net2280_queue: error=-95 [ 90.080217] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 90.080961] net2280 0000:03:00.0: The dmastat return = 5002!! mass_storage usb3.0 (72 MB/s) before patches [ 20.217476] Number of LUNs=8 [ 20.217497] Mass Storage Function, version: 2009/09/11 [ 20.217506] LUN: removable file: (no medium) [ 20.217523] Number of LUNs=1 [ 20.217680] LUN: file: /var/volatile/tmp/kk [ 20.217687] Number of LUNs=1 [ 20.218091] g_mass_storage gadget: Mass Storage Gadget, version: 2009/09/11 [ 20.218100] g_mass_storage gadget: userspace failed to provide iSerialNumber [ 20.218105] g_mass_storage gadget: g_mass_storage ready [ 20.218199] net2280 0000:03:00.0: Operate Defect 7374 workaround soft this time [ 20.218206] net2280 0000:03:00.0: It will operate on cold-reboot and SS connect [ 23.577293] net2280 0000:03:00.0: INFO: Defect 7374 workaround waited about [ 23.577293] 0uSec for Control Read Data Phase ACK [ 23.582088] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 24.194292] nf_conntrack: automatic helper assignment is deprecated and it will be removed soon. Use the iptables CT target to attach helpers instead. [ 24.584649] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 24.686836] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 24.790189] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 24.892078] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 24.995324] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 25.097531] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 25.199237] net2280 0000:03:00.0: net2280_queue: error=-95 [ 25.328681] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 25.329074] net2280 0000:03:00.0: The dmastat return = 5002!! mass_storage usb2.0(34 MB/s/6MB/s)before patches [ 286.105587] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 286.207572] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 286.316432] net2280 0000:03:00.0: net2280_queue: error=-95 [ 286.444463] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 286.444823] net2280 0000:03:00.0: The dmastat return = 5002!! [ 296.625480] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 296.727240] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 296.835332] net2280 0000:03:00.0: net2280_queue: error=-95 [ 296.963211] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 296.963583] net2280 0000:03:00.0: The dmastat return = 5002!! [ 308.027304] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 308.129211] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 308.237172] net2280 0000:03:00.0: net2280_queue: error=-95 [ 308.366546] g_mass_storage gadget: super-speed config #1: Linux File-Backed Storage [ 308.366842] net2280 0000:03:00.0: The dmastat return = 5002!! [ 326.934847] net2280_fifo_flush: Invalid ep=ffff880097bfd3b0 or ep->desc [ 326.935039] net2280_fifo_flush: Invalid ep=ffff880097bfd448 or ep->desc [ 326.935061] net2280_disable: Invalid ep=ffff880097bfd3b0 or ep->desc [ 326.935070] net2280_disable: Invalid ep=ffff880097bfd448 or ep->desc [ 330.117033] g_mass_storage gadget: high-speed config #1: Linux File-Backed Storage [ 331.122255] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 331.224733] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 331.327889] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 331.430273] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 331.534742] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 331.636643] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 331.738695] net2280 0000:03:00.0: net2280_queue: error=-95 mass_storage usb2.0(34 MB/s/6MB/s) after patches [ 90.349765] net2280_fifo_flush: Invalid ep=ffff8800964a13b0 or ep->desc [ 90.349790] net2280_fifo_flush: Invalid ep=ffff8800964a1448 or ep->desc [ 90.349807] net2280_disable: Invalid ep=ffff8800964a13b0 or ep->desc [ 90.349816] net2280_disable: Invalid ep=ffff8800964a1448 or ep->desc [ 92.612408] g_mass_storage gadget: high-speed config #1: Linux File-Backed Storage [ 93.614016] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 93.716153] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 93.819480] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 93.921742] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 94.026849] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 94.129913] net2280 0000:03:00.0: net2280_set_halt_and_wedge: error=-11 [ 94.232088] net2280 0000:03:00.0: net2280_queue: error=-95 On Tue, May 12, 2015 at 8:37 PM, Mian Yousaf Kaukab <yousaf.kaukab@xxxxxxxxx> wrote: > ep_cfg.IN_EP_ENABLE is only valid in advance mode. > > Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@xxxxxxxxx> > --- > drivers/usb/gadget/udc/net2280.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c > index 9871b90..62bc157 100644 > --- a/drivers/usb/gadget/udc/net2280.c > +++ b/drivers/usb/gadget/udc/net2280.c > @@ -1860,8 +1860,8 @@ static void defect7374_enable_data_eps_zero(struct net2280 *dev) > tmp = ((0 << ENDPOINT_NUMBER) | BIT(ENDPOINT_DIRECTION) | > (2 << OUT_ENDPOINT_TYPE) | (2 << IN_ENDPOINT_TYPE) | > ((dev->enhanced_mode) ? > - BIT(OUT_ENDPOINT_ENABLE) : BIT(ENDPOINT_ENABLE)) | > - BIT(IN_ENDPOINT_ENABLE)); > + BIT(OUT_ENDPOINT_ENABLE) | BIT(IN_ENDPOINT_ENABLE) : > + BIT(ENDPOINT_ENABLE))); > > for (i = 1; i < 5; i++) > writel(tmp, &dev->ep[i].cfg->ep_cfg); > -- > 2.3.3 > -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
