Re: [PATCH v2 1/2] USB: io_ti: Add heartbeat to keep idle Edgeport ports from disconnecting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2015-05-11 at 13:58 -0500, Peter Berger wrote:
> On Mon, 2015-05-11 at 11:44 -0400, Don Zickus wrote:
> ...
> > > > 
> > > > Hi,
> > > > 
> > > > you cancel the work on suspend, but what brings it back
> > > > on resume?
> > > > 
> > > > 	Regards
> > > > 		Oliver
> > > 
> > > Hi Oliver:
> > > 
> > > The devices get disconnected and reprobed during resume, so
> > > edge_startup() restarts the heartbeats.
> > 
> > Sounds like a perfect comment to be added in this function for future
> > developers. :-)
> > 
> > Cheers,
> > Don
> 
> 
> Hi Don:
> 
> edge_resume() currently includes this comment:
> 
>   /* Since usb-serial unbinds and reprobes on resume, the re-initialization
>    * (including re-scheduling heartbeat_task) is handled by edge_startup().
>    */
> 
> Is that sufficient?  Should I add something more or move it elsewhere?

Is this universally true? It is true that most systems cut power
in S3. This will lead to a reprobe. But I have a few systems which
can keep ports powered. In those cases it looks to me like usbserial
will do a normal suspend/resume cycle.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux