> -----Original Message----- > From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday, May 07, 2015 8:16 PM > To: Mehresh Ramneek-B31383 > Cc: linux-kernel@xxxxxxxxxxxxxxx; balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; > gregkh@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for > EHCI drv > > On Thu, 7 May 2015, Ramneek Mehresh wrote: > > > Make use of ehci_driver_overrides structure for ehci-fsl driver > > > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx> > > You need to change a lot more than this. See commit a76dd463c58e (USB: > EHCI: make ehci-orion a separate driver) as an example of what is needed. In > the end, ehci-fsl.ko should be a new driver module, not compiled into ehci- > hcd.ko. > I can definitely make this change, but this patch set is about OTG functionality fix for all FSL QorIQ socs. Changes you are asking are for FSL Host driver. For that I can float separate patch/patch set. Hence, I would request you to please accept the Patch series in conext of OTG functionality fix > > + ehci_init_driver(driver, &ehci_fsl_overrides); > > + driver->product_desc = "Freescale On-Chip EHCI Host Controller"; > > + driver->start = ehci_run; > > + driver->start_port_reset = ehci_start_port_reset; > > Why do you want to override driver->start? The default value for this field is > already set to ehci_run. > Will correct this > Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
