On Tue, 5 May 2015, Ramneek Mehresh wrote: > Add workqueue to add/remove host driver (outside interrupt context) > upon each id change > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx> > --- > Changes for v3: > - use overrides for ehci_fsl_overrides > - remove struct ehci_hcd from ehci_fsl > - move ehci_fsl to ehci-fsl.h This patch changes at least three separate things: It adds the workqueue stuff. It replaces ehci_fsl_hc_driver with ehci_fsl_overrides. It adds new fields into the overrides structure. A patch should do only one thing. It certainly shouldn't make three separate, major changes! Also, I'm not going to let you add new fields into the ehci_driver_overrides structure. If you really need to override other routines, copy the approach used by ehci-tegra.c. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html