Re: [PATCH] usb: host: xhci: add mutex for non-thread-safe data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 29 Apr 2015, Petr Mladek wrote:

> On Wed 2015-04-29 09:18:50, Chris Bainbridge wrote:
> > Regression in commit 638139eb95d2d241781330a321e88c8dafe46078
> > Author: Petr Mladek <pmladek@xxxxxxx>
> > Date:   Fri Sep 19 17:32:24 2014 +0200
> > 
> >     usb: hub: allow to process more usb hub events in parallel
> 
> Anyway, I would suggest to revert this commit. I wonder where I had my
> head when I sent it.
> 
> It seems that the other operations with udev->portnum and
> bus->devnum_next are not guared by bus->usb_address0_mutex.
> And it seems that this is not the only operation that need to
> be serialized.

What other operations are you thinking of?  In general, drivers should 
not depend on hub operations being serialized.  If they do, it's a bug 
and it should be fixed.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux