On Tue, Apr 28, 2015 at 04:24:41PM +0300, Heikki Krogerus wrote: > So it can be called from other places later. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > Acked-by: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx> > --- > drivers/usb/dwc3/core.c | 46 ++++++++++++++++++++++++++++++---------------- > 1 file changed, 30 insertions(+), 16 deletions(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 104b236..921f181 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -117,6 +117,33 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc) > } > > /** > + * dwc3_soft_reset - Issue soft reset > + * @dwc: Pointer to our controller context structure > + */ > +static int dwc3_soft_reset(struct dwc3 *dwc) I don't see this being called anywhere else in your series and I would really like to know when we would need to reset the core again ? I don't oppose to having this split to own function because I rather like how it looks, but I don't want to reset the IP needlessly either. cheers -- balbi
Attachment:
signature.asc
Description: Digital signature
