* Felipe Balbi <balbi@xxxxxx> [150428 09:16]: > DM816x PHY uses usb_phy_* methods and because > of that, it must select USB_PHY, however, because > the drivers in question (DM816x, TWL4030 and > OMAP_USB2) sit outside of drivers/usb/ directory, > meaning they can be built even if USB_SUPPORT=n. > > This patches fixes the dependencies by adding > USB_SUPPORT as a dependency and make both drivers > select USB_PHY (which cannot be selected through > menuconfig). > > Note that this fixes some linking breakages when > building with randconfig. > > Cc: Tony Lindgren <tony@xxxxxxxxxxx> Makes sense to me: Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> > Cc: Kishon Vijay Abraham I <kishon@xxxxxx> > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > --- > drivers/phy/Kconfig | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index a53bd5b52df9..2f9ea1e63ccc 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -38,7 +38,9 @@ config ARMADA375_USBCLUSTER_PHY > config PHY_DM816X_USB > tristate "TI dm816x USB PHY driver" > depends on ARCH_OMAP2PLUS > + depends on USB_SUPPORT > select GENERIC_PHY > + select USB_PHY > help > Enable this for dm816x USB to work. > > @@ -97,8 +99,9 @@ config OMAP_CONTROL_PHY > config OMAP_USB2 > tristate "OMAP USB2 PHY Driver" > depends on ARCH_OMAP2PLUS > - depends on USB_PHY > + depends on USB_SUPPORT > select GENERIC_PHY > + select USB_PHY > select OMAP_CONTROL_PHY > depends on OMAP_OCP2SCP > help > @@ -122,8 +125,9 @@ config TI_PIPE3 > config TWL4030_USB > tristate "TWL4030 USB Transceiver Driver" > depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS > - depends on USB_PHY > + depends on USB_SUPPORT > select GENERIC_PHY > + select USB_PHY > help > Enable this to support the USB OTG transceiver on TWL4030 > family chips (including the TWL5030 and TPS659x0 devices). > -- > 2.4.0.rc3 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
