Re: [PATCH] phy: fix Kconfig dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 28, 2015 at 11:09:30AM -0500, Felipe Balbi wrote:
> DM816x PHY uses usb_phy_* methods and because
> of that, it must select USB_PHY, however, because
> the drivers in question (DM816x and OMAP_USB2) sit
> outside of drivers/usb/ directory, they can compile
> even if USB_SUPPORT=n.
> 
> This patches fixes the dependencies by adding
> USB_SUPPORT as a dependency and make both drivers
> select USB_PHY (which cannot be selected through
> menuconfig).
> 
> Note that this fixes some linking breakages when
> building with randconfig.
> 
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
>  drivers/phy/Kconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index a53bd5b52df9..e68ec6a6094c 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -38,7 +38,9 @@ config ARMADA375_USBCLUSTER_PHY
>  config PHY_DM816X_USB
>  	tristate "TI dm816x USB PHY driver"
>  	depends on ARCH_OMAP2PLUS
> +	depends on USB_SUPPORT
>  	select GENERIC_PHY
> +	select USB_PHY
>  	help
>  	  Enable this for dm816x USB to work.

oops, there's twl4030 too. I'll send another version

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux