Hi Geert-san,
Thank you for your comment!
> Sent: Tuesday, April 28, 2015 6:55 PM
>
> Hi Shimoda-san,
>
> On Tue, Apr 28, 2015 at 3:36 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> >> Sent: Tuesday, April 28, 2015 4:45 AM
> >> On Thu, Apr 02, 2015 at 08:22:34PM +0900, Yoshihiro Shimoda wrote:
> >> > According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK
> >> > bit location is bit 8, not bits 9 and 8. So, this patch fixes the
> >> > USBHS_UGSTS_LOCK value.
> >> >
> >> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> >>
> >> this doesn't apply to v4.1-rc1, if it's still needed, please rebase.
> >
> > Thank you for the notice. I found that this patch has been already merged in v4.1-rc1 by Greg.
>
> drivers/usb/phy/phy-rcar-gen2-usb.c (which supports legacy platform data only)
> is unused since commit a483dcbfa21f919c ("ARM: shmobile: lager: Remove
> legacy board support").
>
> It's my understanding this driver has been replaced by a new driver, which
> supports DT only (drivers/phy/phy-rcar-gen2.c).
Yes. You are correct.
> That driver still has the wrong value:
> #define USBHS_UGSTS_LOCK 0x00000300 /* The manuals have 0x3 */
>
> So:
> 1) Shouldn't drivers/phy/phy-rcar-gen2.c be fixed?
I already submitted such a patch. However, the patch is not merged yet.
(I should have sent a ping or something about this patch.)
http://thread.gmane.org/gmane.linux.ports.sh.devel/45089
> 2) Shouldn't drivers/usb/phy/phy-rcar-gen2-usb.c et al be removed?
We should remove this code because legacy board codes were already removed.
(In other words, nobody uses this code now.)
Best regards,
Yoshihiro Shimoda
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
